Support JSXFragment in transform-react-constant-elements#16620
Closed
JLHwung wants to merge 4 commits intobabel:mainfrom
Closed
Support JSXFragment in transform-react-constant-elements#16620JLHwung wants to merge 4 commits intobabel:mainfrom
JLHwung wants to merge 4 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57282 |
nicolo-ribaudo
approved these changes
Jul 26, 2024
liuxingbaoyu
approved these changes
Jul 26, 2024
Member
liuxingbaoyu
left a comment
There was a problem hiding this comment.
It would be great if you could just edit the original PR next time, so that the original author will have completed the first contribution. :)
Contributor
Author
Ah my bad. I will push changes to that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the @keiseiTi 's work on #16582. In this PR we also hoist the JSXFragment if possible. The hoisting logic is mostly shared with the one of JSXElement, except that we can skip handling the
allowMutablePropsOnTagsoption.We also add a few new test cases for other valid JSXElement's parent node types.