Ensure enum members syntactically determinable to be strings do not get reverse mappings#16602
Merged
JLHwung merged 2 commits intobabel:mainfrom Jul 22, 2024
Conversation
Member
liuxingbaoyu
commented
Jul 2, 2024
| Q | A |
|---|---|
| Fixed Issues? | Ref: microsoft/TypeScript#57686 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57236 |
087567e to
91b4f09
Compare
JLHwung
approved these changes
Jul 2, 2024
nicolo-ribaudo
approved these changes
Jul 3, 2024
Comment on lines
+130
to
+133
| expr.operator === "+" && | ||
| (isSyntacticallyString(left as t.Expression) || | ||
| isSyntacticallyString(right)) | ||
| ); |
Member
There was a problem hiding this comment.
We have a test case that covers this branch, right?
Member
Author
There was a problem hiding this comment.
Yes, we have a test that has a string on the left.
This was referenced Aug 16, 2024
This was referenced Aug 17, 2024
This was referenced Aug 17, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 5, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.