Some minor parser performance improvements for ts#16461
Merged
nicolo-ribaudo merged 25 commits intobabel:mainfrom Jul 17, 2024
Merged
Some minor parser performance improvements for ts#16461nicolo-ribaudo merged 25 commits intobabel:mainfrom
nicolo-ribaudo merged 25 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57365 |
liuxingbaoyu
commented
May 1, 2024
| return require("./babel-worker.cjs"); | ||
| } | ||
| const worker = new JestWorker(require.resolve("./babel-worker.cjs"), { | ||
| enableWorkerThreads: true, |
Member
Author
There was a problem hiding this comment.
This is 0.3s faster on my local machine. :)
Contributor
There was a problem hiding this comment.
Unfortunately it will be 1s slower on mac. But anyway it is not really noticeable.
# enableWorkerThreads: true
$ make clean-lib && time yarn gulp build-babel
yarn gulp build-babel 11.68s user 1.15s system 427% cpu 3.001 total
# enableWorkerThreads: false
$ make clean-lib && time yarn gulp build-babel
yarn gulp build-babel 10.75s user 1.10s system 404% cpu 2.930 total
Comment on lines
+31
to
+42
| copyFileSync( | ||
| require.resolve("@babel-baseline/parser"), | ||
| "./parser-baseline.cjs" | ||
| ); | ||
| copyFileSync( | ||
| "../../../packages/babel-parser/lib/index.js", | ||
| "./parser-current.cjs" | ||
| ); | ||
|
|
||
| const baseline = require("./parser-baseline.cjs"); | ||
| const current = require("./parser-current.cjs"); |
Member
Author
There was a problem hiding this comment.
I had to do this otherwise I would get unstable benchmarks for current and I don't understand why.
I suspect that might have something to do with it, but it's still weird. It shouldn't cause any effect.
e35eb9e to
8dd23f3
Compare
8dd23f3 to
2dbadd4
Compare
f5dce56 to
c479859
Compare
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 5, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2The performance improvement is only 1%-5%. :)