Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57350 |
Member
|
Finally reviewing this, sorry it took so long.
This is covered by the Can you add a test for the execution order between property access and arguments evaluation? let argsEval = false;
let err = {};
class A {
get x() { throw {} }
}
class B extends A {
method() {
super.x(argsEval = true);
}
}
expect(() => new B().method()).toThrow(err);
expect(argsEval).toBe(false); |
dd1bc89 to
92e2168
Compare
JLHwung
approved these changes
Jul 9, 2024
nicolo-ribaudo
approved these changes
Jul 12, 2024
9c609ac to
8cb4293
Compare
This was referenced Aug 16, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 5, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I personally don't like having to call

getPrototypeOfevery time because it's slow, but we have a test that relies on this behavior.