Skip to content

fix: support await as for-of-lhs#15134

Merged
JLHwung merged 1 commit into
babel:mainfrom
JLHwung:fix-15127
Nov 5, 2022
Merged

fix: support await as for-of-lhs#15134
JLHwung merged 1 commit into
babel:mainfrom
JLHwung:fix-15127

Conversation

@JLHwung

@JLHwung JLHwung commented Nov 4, 2022

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #15127
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we mark await of ... as an ambiguous await expression, so we don't try to parse an await expression in for (await of []) in order to throw a better error message. This issue is a regression introduced in #12520.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Nov 4, 2022
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53360/

@JLHwung JLHwung merged commit ce09a26 into babel:main Nov 5, 2022
@JLHwung JLHwung deleted the fix-15127 branch November 5, 2022 13:10
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 5, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Babel crashes when using await as an identifier in ForInOfHead

4 participants