Add a missing dependency on @babel/types to @babel/parser#15042
Add a missing dependency on @babel/types to @babel/parser#15042
@babel/types to @babel/parser#15042Conversation
aa5ce21 to
571bb7c
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53151/ |
|
I see the concern with the added dependency - but without this, it just doesn't work with strict package managers and can cause some weird issues in the ones that rely on the flattened |
|
I personally prefer to remove the |
While that is correct both Yarn and pnpm declare this dependency automatically so in this case they're not affected. |
|
I've looked at the past two PRs and it seems that only bundling of types is an acceptable solution. Thanks to merceyz for the information, in my opinion, since yarn and pnpm already have |
This is an actual dependency of the typings contained in this package and thus should be declared explicitly:
babel/packages/babel-parser/typings/babel-parser.d.ts
Line 14 in 0b0f083
Fixes #1, Fixes #2