Define the global regeneratorRuntime in @babel/runtime/regenerator#14581
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 25, 2022
Merged
Define the global regeneratorRuntime in @babel/runtime/regenerator#14581nicolo-ribaudo merged 1 commit intobabel:mainfrom
regeneratorRuntime in @babel/runtime/regenerator#14581nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Closed
1 task
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52006/ |
JLHwung
approved these changes
May 25, 2022
| regeneratorRuntime = runtime; | ||
| } catch (accidentalStrictMode) { | ||
| if (typeof globalThis === "object") { | ||
| globalThis.regeneratorRuntime = runtime; |
Contributor
There was a problem hiding this comment.
Can we remove the global definition behind the BABEL_8_BREAKING flag?
Member
Author
There was a problem hiding this comment.
No, this file isn't compiled.
liuxingbaoyu
approved these changes
May 25, 2022
1 task
PeachScript
reviewed
May 25, 2022
| module.exports = require("../helpers/regeneratorRuntime")(); | ||
| // TODO(Babel 8): Remove this file. | ||
|
|
||
| const runtime = require("../helpers/regeneratorRuntime")(); |
Contributor
There was a problem hiding this comment.
It is more appropriate to use var like runtime helpers, otherwise, this code needs to be compiled into es5 with babel self 👀
Member
Author
There was a problem hiding this comment.
Sorry for that, we released the fix 2 minutes ago!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if
@babel/runtimewas documented as being a pure set of helpers and the@babel/runtime/regeneratorentry point exported theregeneratorRuntimehelper, it also accientally used to define aregeneratorRuntimeglobal due to its depenency onregenerator-runtime.Many packages relied on this global being "accidentally" present due to something else in the dependencies tree loading
@babel/runtime/regenerator. I'm annoyed by this, but let's restore the old (accidental and undocumented) behavior because I have already seen multiple repositories with this problem. We'll remove this legacy entry point in Babel 8.Closes #14576.