Skip to content

Fix jest-runner support#14572

Closed
liuxingbaoyu wants to merge 6 commits intobabel:mainfrom
liuxingbaoyu:support-jest-runner
Closed

Fix jest-runner support#14572
liuxingbaoyu wants to merge 6 commits intobabel:mainfrom
liuxingbaoyu:support-jest-runner

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented May 21, 2022

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? ×
Minor: New Feature? ×
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

I suspect the ci failure in the main branch has something to do with the worker_threads used by jest-light-runner.

I'm worried it will get worse in the future.

Let's keep jest-runner available as a backup.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 21, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52145/

@liuxingbaoyu liuxingbaoyu added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 25, 2022
@liuxingbaoyu liuxingbaoyu force-pushed the support-jest-runner branch from 5da6784 to 908eea2 Compare June 2, 2022 22:14
@liuxingbaoyu liuxingbaoyu marked this pull request as draft June 3, 2022 00:08
@nicolo-ribaudo
Copy link
Copy Markdown
Member

@liuxingbaoyu I haven't seen the failure for a while: do we still need this?

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

This happens quite often when I test coverage locally, but it really doesn't exist on CI. This should have been resolved in another PR, but that one is more complicated. This PR should mostly be fine, I tend to keep a JEST running, what do you think?

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants