Skip to content

Support frozen built-ins in @babel/runtime#14537

Merged
nicolo-ribaudo merged 5 commits intobabel:mainfrom
Jack-Works:Jack-Works-patch-1
May 25, 2022
Merged

Support frozen built-ins in @babel/runtime#14537
nicolo-ribaudo merged 5 commits intobabel:mainfrom
Jack-Works:Jack-Works-patch-1

Conversation

@Jack-Works
Copy link
Copy Markdown
Contributor

@Jack-Works Jack-Works commented May 7, 2022 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #14527
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 7, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51994/

liuxingbaoyu
liuxingbaoyu requested changes May 8, 2022
View reviewed changes
@Jack-Works
Copy link
Copy Markdown
Contributor Author

Jack-Works commented May 8, 2022

hmm 1 test failed but I don't know how to fix it, it does not have a meaningful error message

@liuxingbaoyu
Copy link
Copy Markdown
Member

liuxingbaoyu commented May 8, 2022

The test is a bit erratic and can be ignored.

:)

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented May 17, 2022

Thanks for the PR! Didn't you mention a similar problem with also a different helper? #14527 (comment)

I hope one day we'll be able to run our tests with --frozen-intrinsics

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 17, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title fix: Cannot add property __esModule, object is not extensible on @babel/helpers Support frozen built-ins in @babel/runtime May 17, 2022
@Jack-Works
Copy link
Copy Markdown
Contributor Author

Jack-Works commented May 17, 2022

Thanks for the PR! Didn't you mention a similar problem with also a different helper? #14527 (comment)

I hope one day we'll be able to run our tests with --frozen-intrinsics

Done!

@liuxingbaoyu
Copy link
Copy Markdown
Member

liuxingbaoyu commented May 17, 2022 •
edited
Loading

packages\babel-runtime\helpers\get
packages\babel-runtime\helpers\extends

These two seem to need to do the same.

nicolo-ribaudo
nicolo-ribaudo approved these changes May 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

liuxingbaoyu
liuxingbaoyu reviewed May 22, 2022
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo reviewed May 22, 2022
View reviewed changes
@nicolo-ribaudo nicolo-ribaudo merged commit 62fd56f into babel:main May 25, 2022
@deivid-rodriguez deivid-rodriguez mentioned this pull request May 26, 2022
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/runtime/helpers/setPrototypeOf.js throws error: Cannot add property __esModule, object is not extensible

4 participants

@Jack-Works @babel-bot @liuxingbaoyu @nicolo-ribaudo