Never hoist JSX elts referencing vars from the current scope#14536
Merged
JLHwung merged 1 commit intobabel:mainfrom May 9, 2022
Merged
Never hoist JSX elts referencing vars from the current scope#14536JLHwung merged 1 commit intobabel:mainfrom
JLHwung merged 1 commit intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
May 6, 2022
| @@ -0,0 +1,10 @@ | |||
| function RoutesComponent() { | |||
Member
Author
There was a problem hiding this comment.
The old output was
var _Component;
function RoutesComponent() {
return (
<Routes>
{(c) => {
{
const Component = c;
return _Component || (_Component = <Component />);
}
}}
</Routes>
);
}
nicolo-ribaudo
commented
May 6, 2022
|
|
||
| // Only hoist if it would give us an advantage. | ||
| if (targetScope === jsxScope) return; | ||
| for (let currentScope = jsxScope; ; ) { |
Member
Author
There was a problem hiding this comment.
This is now more complex, because in cases like
function f() {
let Component;
{
return <Component />;
}
}jsxScope is the block statement while targetScope is the function: we still do not want to hoist the element, because it's unnecessary (there are already 2-3 tests covering this).
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51873/ |
jridgewell
approved these changes
May 6, 2022
JLHwung
approved these changes
May 9, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.