Skip to content

Update jest-light-runner#14488

Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom
nicolo-ribaudo:up-jest-light-runner
May 1, 2022
Merged

Update jest-light-runner#14488
nicolo-ribaudo merged 2 commits intobabel:mainfrom
nicolo-ribaudo:up-jest-light-runner

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 24, 2022 •
edited by gitpod-io bot
Loading

Q                       A
License MIT

The only relevant changes for us are --maxWorkers and --runInBand support.

Ref #14486.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Apr 24, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51817/

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Apr 24, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51737/

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft April 24, 2022 20:23
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review April 26, 2022 13:12
nicolo-ribaudo
nicolo-ribaudo commented Apr 26, 2022
View reviewed changes
Comment thread test/testSetupFile.js
@@ -1 +0,0 @@
jest.setTimeout(10000);
Copy link
Copy Markdown
Member Author

@nicolo-ribaudo nicolo-ribaudo Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older jest-light-runner versions did not support setupFilesAfterEnv, so this file was not loaded at all (and thus we don't really need it).

The latest jest-light-runner supports setupFilesAfterEnv, but it does not support jest.setTimeout.

This was referenced Apr 27, 2022
Merged
Merged
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Apr 30, 2022

I'm merging this when it's green, since:

  • it's just a devDep update
  • already two people complained that without --runInBand support it's impossible to debug using the Node.js/Chrome debugger 😬

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Apr 30, 2022

The "E2E tests (breaking) / Test (babel)" failure might be related, I'll investigate tomorrow.

@nicolo-ribaudo nicolo-ribaudo force-pushed the up-jest-light-runner branch from ba7e231 to 484775b Compare May 1, 2022 15:29
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented May 1, 2022

Ok it was just a timeout, I restarted it and it passed.

@nicolo-ribaudo nicolo-ribaudo merged commit 0b5b009 into babel:main May 1, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the up-jest-light-runner branch May 1, 2022 15:43
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @existentialism @jridgewell