Skip to content

Fix regexpu-core bundling in @babel/standalone#13767

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:fix-standalone-unicode-data
Sep 15, 2021
Merged

Fix regexpu-core bundling in @babel/standalone#13767
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:fix-standalone-unicode-data

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 15, 2021

Q                       A
Fixed Issues? Fixes #13765
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I'm not sure how it could work in the past, since Node.js loads the CJS version of the plugin and we only patched the ESM version.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: standalone labels Sep 15, 2021
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48734/

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 794e289:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I am wondering why #13765 was not caught by

Babel.transform("/\\p{L}/u", {

Should we mock the require in this test?

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

Should we mock the require in this test?

Ideally I would like to propose a new @rollup/plugin-commonjs option that stops the final bundle from actually containing a require() call. Many people test their bundles in Node.js where require should be available, and then run them in browsers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't compile /\p{Letter}/u in REPL

4 participants