Skip to content

Disallow #a in #b in c and similar expressions#13727

Merged
nicolo-ribaudo merged 6 commits into
babel:mainfrom
nicolo-ribaudo:private-in-private-in
Sep 4, 2021
Merged

Disallow #a in #b in c and similar expressions#13727
nicolo-ribaudo merged 6 commits into
babel:mainfrom
nicolo-ribaudo:private-in-private-in

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Sep 2, 2021 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #13726
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label Sep 2, 2021
@babel-bot

babel-bot commented Sep 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48524/

@codesandbox-ci

codesandbox-ci Bot commented Sep 2, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7779a6c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Sep 2, 2021
View reviewed changes
Comment thread packages/babel-parser/src/parser/expression.js Outdated
JLHwung
JLHwung reviewed Sep 2, 2021
View reviewed changes
Comment thread packages/babel-parser/src/parser/expression.js
@nicolo-ribaudo @JLHwung
Update packages/babel-parser/src/parser/expression.js
55ec170 
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@JLHwung

JLHwung commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Can you add a new test case?

class C {
  #x;
  async test() {
    await #x in this
  }
}

It was parsed successfully but should throw, probably fixed in this PR.

JLHwung
JLHwung reviewed Sep 3, 2021
View reviewed changes
Comment thread packages/babel-parser/src/parser/expression.js

return this.parseExprOp(
this.parseMaybeUnary(),
this.parseMaybeUnaryOrPrivate(),

This comment was marked as resolved.

Sign in to view

@nicolo-ribaudo nicolo-ribaudo Sep 3, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done at https://github.com/babel/babel/pull/13727/files#diff-f876d1e822b0978b9c6de30b9fc6e96e2309c853a694feea274ecccf1d1d9f15R2935.

@nicolo-ribaudo nicolo-ribaudo merged commit 44388e6 into babel:main Sep 4, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the private-in-private-in branch September 4, 2021 08:05
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 5, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jridgewell jridgewell jridgewell approved these changes

@JLHwung JLHwung JLHwung approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Brand Check for Private Fields

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Private Brand Check incorrectly allowed as RHS of in operator

5 participants

@nicolo-ribaudo @babel-bot @JLHwung @jridgewell @sosukesuzuki