fix(ts): raise error for export default interface {}#13622
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Aug 2, 2021
Merged
fix(ts): raise error for export default interface {}#13622nicolo-ribaudo merged 1 commit intobabel:mainfrom
export default interface {}#13622nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47771/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c22b024:
|
4ecb14a to
eb419e2
Compare
fedeci
reviewed
Jul 31, 2021
fedeci
reviewed
Jul 31, 2021
fedeci
reviewed
Jul 31, 2021
export default interface {}
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thanks! Except for two minor comments, I think we can modify this PR's implementation to further improve the current generated AST.
packages/babel-parser/test/fixtures/typescript/interface/export-default/output.json
Show resolved
Hide resolved
fedeci
reviewed
Aug 1, 2021
fedeci
reviewed
Aug 1, 2021
fedeci
approved these changes
Aug 2, 2021
This was referenced Aug 5, 2021
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.