Skip to content

Disable smart pipes in v8.0#13488

Closed
js-choi wants to merge 4 commits intobabel:feat-7.15.0/hack-pipesfrom
js-choi:remove-smart-pipes-8.0
Closed

Disable smart pipes in v8.0#13488
js-choi wants to merge 4 commits intobabel:feat-7.15.0/hack-pipesfrom
js-choi:remove-smart-pipes-8.0

Conversation

@js-choi
Copy link
Copy Markdown
Contributor

@js-choi js-choi commented Jun 19, 2021

Q                       A
Fixed Issues? None
Patch: Bug Fix? No
Major: Breaking Change? Yes
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link babel/website#2541
Any Dependency Changes? No
License MIT

This disables smart-mix pipes when BABEL_8_BREAKING is active. Smart-mix pipes were withdrawn as a TC39 proposal in favor of Hack pipes. It depends on #13416. See also #13191, #13413.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2804ef:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@js-choi js-choi force-pushed the remove-smart-pipes-8.0 branch from 7a31ca4 to ef7560f Compare June 19, 2021 02:34
@js-choi js-choi force-pushed the remove-smart-pipes-8.0 branch from ef7560f to b2804ef Compare June 19, 2021 02:53
@js-choi js-choi marked this pull request as ready for review June 19, 2021 03:01
@js-choi
Copy link
Copy Markdown
Contributor Author

js-choi commented Jul 6, 2021

This pull request will not be merged in v7.15.0 but rather will merged in a future patch version, as per #13413 (comment).

I plan to resolve the new merge conflicts after v7.15.0 is released later this year.

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.15.0/hack-pipes branch 2 times, most recently from 08835bf to b427f52 Compare July 6, 2021 18:19
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.15.0/hack-pipes branch from 81af5a7 to c29531e Compare August 3, 2021 21:21
@nicolo-ribaudo nicolo-ribaudo deleted the branch babel:feat-7.15.0/hack-pipes August 3, 2021 21:30
@js-choi js-choi deleted the remove-smart-pipes-8.0 branch August 4, 2021 13:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants