Conversation
| "samsung": "13", | ||
| "electron": "8.0" | ||
| }, | ||
| "bugfix/transform-v8-spread-parameters-after-optional-chaining": { |
There was a problem hiding this comment.
WDYT bugfix/v8-spread-parameters-after-optional-chaining? I can't think of any term other transform that could follow bugfix/.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44368/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d14eab4:
|
| "samsung": "13", | ||
| "electron": "8.0" | ||
| }, | ||
| "bugfix/transform-v8-spread-parameters-after-optional-chaining": { |
There was a problem hiding this comment.
I think we should also bump private-methods as
new class { #m() {} constructor() { null?.#m(...[], 1) } }also throws.
Or we transpile it to
new class { #m() {} constructor() { null == null ? undefined : null.#m(...[], 1) } }so it is still good to assume v8 84 has full support of private methods.
|
@JLHwung In that case we should only transpile the optional chain, leaving private methods as-is. |
This PR bumps
compat-tableand adds support data on the upcomingbugfix/transform-v8-spread-parameters-after-optional-chaining.