Don't enable class features by default in estree#12867
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Feb 23, 2021
Merged
Don't enable class features by default in estree#12867nicolo-ribaudo merged 3 commits intobabel:mainfrom
estree#12867nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42048/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11ae89a:
|
This was referenced Feb 23, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
This was referenced Mar 15, 2021
build(deps): bump @babel/plugin-proposal-decorators from 7.10.5 to 7.13.5
ChatterlyOSE/Chatterly#594
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that:
estreeparser option means "give me an estree-compatible AST"estreespec got the definition for class fields and private elementsestreeparser option to produce themestreeoption is for, but this breaks every older version of@babel/eslint-parserorbabel-eslintI put this behind a new option, to revert the regression. Technically this is a breaking change compared to 7.13.0, but semver itself recommends reverting accidental breakages to restore the previous working state.