Rename index.mjs to _index.mjs in @babel/runtime#12855
Rename index.mjs to _index.mjs in @babel/runtime#12855nicolo-ribaudo merged 2 commits intobabel:mainfrom
index.mjs to _index.mjs in @babel/runtime#12855Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00b6291:
|
require condition to @babel/runtimeindex.mjs to _index.mjs in `@babel/runtime
e2883fe to
50514e1
Compare
|
I can confirm that this works in my local gatsby project. |
index.mjs to _index.mjs in `@babel/runtimeindex.mjs to _index.mjs in @babel/runtime
|
Thanks 🙏 |
|
@KyleAMathews We are releasing (https://github.com/babel/babel/actions/runs/591028231) |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41949/ |
|
@nicolo-ribaudo thanks so much! Confirmed Gatsby is back in business with 7.13.1 🎉 |
|
I'm going to sleep now, but tomorrow I'll DM you to see how we can add Gatsby as an e2e test 😬 |
|
Excellent! |
|
@nicolo-ribaudo thank you truly for the quick turnaround on this. We at Gatsby appreciate this, and so too do our users. We'd love to chat about e2e test, so let us know how we can help ensure we can automate and track this case for the future 👍 |
This should fix #12854, but for some reason webpack still loads the.mjsversion when usingrequire()🤔Maybe it's a caching problem, but what I see locally is that even uses the.mjsversion even if I remove every mention of.mjsin@babel/runtime'spackage.jsonThe problem is that Webpack 4 always loads
index.mjsif there are bothindex.jsandindex.mjs, and there is no way (unless you update the webpack config) to tell it to loadindex.js.