[babel 8] Enable allowDeclareFields option by default w/ Flow#12457
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Dec 8, 2020
Merged
[babel 8] Enable allowDeclareFields option by default w/ Flow#12457nicolo-ribaudo merged 2 commits intobabel:mainfrom
allowDeclareFields option by default w/ Flow#12457nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Dec 8, 2020
| }, | ||
| }; | ||
|
|
||
| delete taskOpts.BABEL_8_BREAKING; |
Member
Author
There was a problem hiding this comment.
Without this @babel/core throws about the unknown BABEL_8_BREAKING option.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34237/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 981e683:
|
cherr-pick of 4903e2e Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
c4a49e0 to
981e683
Compare
JLHwung
approved these changes
Dec 8, 2020
hzoo
approved these changes
Dec 8, 2020
allowDeclareFields Flow option by defaultallowDeclareFields option by default w/ Flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of 635c7fd. The original PR is #10120, but after many rebases it has been completely rewritten.