Skip to content

Super property eval order #11480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 5 commits into from
Apr 25, 2020
Merged

Super property eval order #11480

nicolo-ribaudo merged 5 commits into from
Apr 25, 2020

Conversation

@jridgewell
Copy link
Member

@jridgewell jridgewell commented Apr 25, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Retrieves the this binding to be used for super[prop] expressions, before evaluating the prop. Aligns us with tc39/ecma262#1207.

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 25, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21348/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8272c2c:

Sandbox Source
agitated-grothendieck-e0qvb Configuration

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 25, 2020

Can you add an exec test for super[super(), "prop"]?

@jridgewell
Copy link
Member Author

jridgewell commented Apr 25, 2020

Can you add an exec test for super[super(), "prop"]?

See https://github.com/babel/babel/pull/11480/files#diff-665fbe1408e090af594d4d304776ef52R16

@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Classes labels Apr 25, 2020
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 25, 2020

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 0bbf2da into babel:master Apr 25, 2020
@jridgewell jridgewell deleted the super-property-eval-order branch April 25, 2020 21:23
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Classes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jridgewell @babel-bot @nicolo-ribaudo @existentialism