Skip to content

Refactor parseSubscript #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLHwung merged 4 commits into from
Dec 30, 2019
Merged

Refactor parseSubscript #10937

JLHwung merged 4 commits into from
Dec 30, 2019

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 29, 2019 •
edited
Loading

Q                       A
Fixed Issues? It happens to fix this REPL invalid case, which should throw.
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

I reorganize the process flow in parser.prototype.parseScript, the code is now more succinct. It happens to fix an edge case of flow typecast in optional call params.

Notable changes:

  • The OptionalMemberExpression is generated in a single branch
  • The OptionalCallExpression shares the same extra logic with CallExpression. It fixes the bug by calling toReferencedListDeep, same as CallExpression.

The new process flow is almost copied from acornjs/acorn#891.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: flow pkg: parser labels Dec 29, 2019
@JLHwung JLHwung mentioned this pull request Dec 29, 2019
Merged
existentialism
existentialism approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JLHwung JLHwung merged commit 30449fe into babel:master Dec 30, 2019
@JLHwung JLHwung deleted the refactor-parseSubscript branch December 30, 2019 21:11
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
Closed
This was referenced Mar 22, 2020
Open
Open
This was referenced Mar 24, 2020
Open
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JLHwung @existentialism @nicolo-ribaudo