Skip to content

fix: Use the recommended property to specify repository URL#10665

Merged
JLHwung merged 1 commit intobabel:masterfrom
maksimr:patch-1
Nov 6, 2019
Merged

fix: Use the recommended property to specify repository URL#10665
JLHwung merged 1 commit intobabel:masterfrom
maksimr:patch-1

Conversation

@maksimr
Copy link
Copy Markdown
Contributor

@maksimr maksimr commented Nov 6, 2019

Use recommended by npm property to specify repository URL
https://docs.npmjs.com/files/package.json#repository

Otherwise, it breaks some tools which relay on this convention for example "nlf" package
https://github.com/iandotkelly/nlf/blob/master/lib/nlf.js#L284-L285

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Use recommended by npm property to specify repository URL
https://docs.npmjs.com/files/package.json#repository

Otherwise, it breaks some tools which relay on this convention for example "nlf" package
https://github.com/iandotkelly/nlf/blob/master/lib/nlf.js#L284-L285
@buildsize
Copy link
Copy Markdown

buildsize bot commented Nov 6, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 2 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 2 bytes (0%)
babel.js 2.96 MB 2.96 MB 2 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 2 bytes (0%)
test262.tap 4.84 MB [deleted]

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit 3ab035b into babel:master Nov 6, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants