fix: Exclude catch clause from let identifier error#10559
Merged
nicolo-ribaudo merged 5 commits intobabel:masterfrom Oct 17, 2019
zant:bugfix/10413
Merged
fix: Exclude catch clause from let identifier error#10559nicolo-ribaudo merged 5 commits intobabel:masterfrom zant:bugfix/10413
nicolo-ribaudo merged 5 commits intobabel:masterfrom
zant:bugfix/10413
Conversation
Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
existentialism
approved these changes
Oct 17, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new getter in
scopeto know if the current scope is a catch block, and then use that property to exclude catch blocks from the original conditionI also tried to go the other way around and implicitly exclude the catch block by raising the error not on lexical binding, but only on
letandconstdeclarations, but i couldn’t find a way to check the kind of the variable declaration when handling an identifier's nameI think other solution could be adding a new scope flag for catch blocks, but i'm not really sure
What do you guys think?