Add filename to transform error#10511
Merged
nicolo-ribaudo merged 5 commits intobabel:masterfrom Oct 1, 2019
Merged
Conversation
nicolo-ribaudo
approved these changes
Sep 30, 2019
hzoo
approved these changes
Sep 30, 2019
Contributor
Author
I think it is still slightly early to extract the error messages processing into separate utils. I would suggest refactoring when we are working on the debug mode error message. |
Member
|
Same haha! I think not being to know the file where the error is happening to due an internal error (not syntax error) would be pretty bad on our part so best to make filing an issue easy! 🙌 |
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous art: In the parsing stage babel-core will add filename to the error message
babel/packages/babel-core/src/transformation/normalize-file.js
Line 145 in 94fcabc
In this PR we add
filenameto the error message to both transforming phrase and generating phrase. It should help developer debug which file actually causes babel transformer/generator to throw.