Correctly delegate .return() in async generator#10422
Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom Nov 4, 2019
Merged
Correctly delegate .return() in async generator#10422nicolo-ribaudo merged 4 commits intobabel:masterfrom
nicolo-ribaudo merged 4 commits intobabel:masterfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11556/ |
JLHwung
reviewed
Sep 10, 2019
...-proposal-async-generator-functions/test/fixtures/yield-star/throw-method-with-catch/exec.js
Outdated
Show resolved
Hide resolved
Member
Author
|
I think that the tests are failing on node 6 because of a generator bug in that version. |
522ab5d to
9745694
Compare
JLHwung
approved these changes
Nov 3, 2019
9745694 to
4b4a14c
Compare
Member
Author
|
✔️ |
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(rant) Debugging this thing was really painful. When working with async code and generators, node was trying to be helpful by stepping into code in the next tick and it missed a lot of stack frames.
Disclaimer: I'm only 80% sure that this PR is correct.
cc @zenparsing "Git blame" attributes this code to only you. If you have time to review this code it would be really appreciated, since propbably you are one of the only persons which fully understand how it works 😅