fix: pass optionLoc when validating plugin object#10402
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Sep 11, 2019
Merged
fix: pass optionLoc when validating plugin object#10402nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Conversation
| }; | ||
|
|
||
| expect(() => loadConfig(opts)).toThrow( | ||
| /\.inhertis must be a function, or undefined/, |
Member
There was a problem hiding this comment.
What is the current message?
Contributor
Author
There was a problem hiding this comment.
Quotes from #9877
"Assertion failure: Unknown type undefined" error instead of the proper error; "inherits must be a function, or undefined"
nicolo-ribaudo
approved these changes
Sep 6, 2019
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11498/ |
danez
approved these changes
Sep 11, 2019
This was referenced Oct 3, 2019
This was referenced Oct 22, 2019
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct option loc and pass it to the validator so that it can print helpful messages on validation error.