fix: assign trailing comment to ObjectProperty only when inside an ObjectExpression#10292
Merged
existentialism merged 1 commit intobabel:masterfrom Aug 13, 2019
Merged
fix: assign trailing comment to ObjectProperty only when inside an ObjectExpression#10292existentialism merged 1 commit intobabel:masterfrom
existentialism merged 1 commit intobabel:masterfrom
Conversation
81f4ab4 to
d58b88e
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11280/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11279/ |
nicolo-ribaudo
approved these changes
Aug 4, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to babel/babylon#478.
When assigning tailing comment to an ObjectProperty, we should ensure the comment is inside the ObjectExpression, otherwise we would incorrectly assign a trailing comment of ObjectExpression, meanwhile the leading comment of subsequence statements, to this ObjectProperty.