updated ParsePlugin type definition#10259
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Jul 26, 2019
letladi:issue-10186
Merged
updated ParsePlugin type definition#10259nicolo-ribaudo merged 2 commits intobabel:masterfrom letladi:issue-10186
nicolo-ribaudo merged 2 commits intobabel:masterfrom
letladi:issue-10186
Conversation
…e ParserPlugin type. closes #10186
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11239/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11225/ |
Contributor
|
Could you link the fixed issue in the description? i.e. It would update the issue status once this PR gets merged. Protip: When you are creating a pull request, there will be a PR template. Try to spend some time filling in the form, it will help reviewers know what it the type of PR (bugfix/feature/internal) in first glance. |
Contributor
Author
|
Thanks for the tip. I will keep that in mind going forward. |
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I now that they were already out of order, but could you sort them alphabetically?
Contributor
Author
|
Ok cool. Will do 👍🏽 |
JLHwung
approved these changes
Jul 25, 2019
existentialism
approved these changes
Jul 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10186