Add regression tests for regenerator#10223
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Mar 23, 2020
Merged
Conversation
nicolo-ribaudo
commented
Jul 15, 2019
| while (1) switch (_context.prev = _context.next) { | ||
| case 0: | ||
| _actions.someAction = (bar, function () { | ||
| throw new Error('"' + "someAction" + '" is read-only.'); |
Member
Author
There was a problem hiding this comment.
This is wrong, waiting for facebook/regenerator#377
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11141/ |
1 similar comment
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11141/ |
thiagoarrais
suggested changes
Aug 14, 2019
| "main": "lib/index.js", | ||
| "dependencies": { | ||
| "regenerator-transform": "^0.14.0" | ||
| "regenerator-transform": "^0.14.2" |
Contributor
There was a problem hiding this comment.
Seems like facebook/regenerator#377 is available in regenerator-transform:0.14.1 shouldn't this be 0.14.1?
Suggested change
| "regenerator-transform": "^0.14.2" | |
| "regenerator-transform": "^0.14.1" |
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
You're right. Sorry. My bad.
Member
Author
|
@benjamn Could a new version of |
Member
Author
|
Regenerator has been merged in #11191, I'll merge these tests. |
4274d65 to
e02a865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regeneratorupdated