Conversation
|
Need to implement no-newline before bang (to prevent ASI from changing the meaning of existing programs). |
|
Did you perhaps submit this to the wrong repo? I see that you changed the package name, and as-is I don't think it makes sense for us to have a WIP patch open when there is no proposal. |
|
The stage 0 proposal is coming. I thought this PR would be a good way to have other collaborators discuss the changes until it would no longer be WIP. If that's not acceptable, I will close this PR and find a forum elsewhere. |
|
@michaelfig: I see you changed this to an agoric parser. Does that mean @erights will be presenting this at the next meeting? |
|
Assuming this is something that is being presented at the next meeting, I don't necessarily mind having the PR open. We definitely require something to have a stage 0 proposal before landing it in the parser. That said, we also generally want to be very cautious about landing things too early, because once things land, we can't change it and need to support it, even if there are further later changes to the proposal syntax that then might require the introduction of even more parser plugins. |
|
@jridgewell, possibly. It depends on his schedule. I'm currently experimenting with the parser, but the details could change significantly based on what is actually proposed. |
|
@loganfsmyth, I don't want to merge this PR until it actually satisfies all parties and doesn't look like it will change. Until then, WIP! |
|
Okie doke, sounds good. |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11698/ |
d37a44b to
af135a6
Compare
|
Flaky tests? |
f654b63 to
4b00e82
Compare
4b00e82 to
5d22fdf
Compare
|
This proposed syntax has been changed from infix bang (!) to wavy dot (~.), as documented in the eventual send syntax proposal. |
43f2b5f to
c7d325a
Compare
5dc45bf to
18adaf9
Compare
Add
@babel/parsersupport for infix bang syntax, activated by:where
resolverObjectcan be any identifier whoseresolve()method creates aPromisewhich understands the remote promise protocol.becomes:
This PR will be fleshed out with more documentation when there is a stage0 proposal for it.