-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Closed
Labels
area: helpersoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue
Description
Having the version of babel-runtime be tied to core-js has caused us issues so Logan has suggested we split it out. Just writing down in an issue what I think we can do? (There's plenty of stuff to fix but we can always move things till later since we just want an RC too).
@babel/plugin-transform-runtimeshould only transform the babel helpers (devDep) instead of also doing it forcore-jsandregenerator. The other two would be in another package likebabel-runtime-corejs2? (not sure if regenerator has to be it's own thing again or not)- it currently has a few options that we can change.
helpers: true: this is the whole point now so we can just remove this option.polyfillfalse: removing this optionregeneratorfalse: removing this option (maybe)?moduleNamefalse: not even sure who is using this anymore maybe CRA?useBuiltInstrue: by default?useESModules- true: or remove the option?
@babel/runtimeshould only contain helpers code (dependency)?- I think we have 4 copies of helpers: useBuiltIns + useESModules combo.
Yes this is more configuration but you don't have to use it. Ideally with this we would just include @babel/plugin-transform-runtime as part of preset-env by default? and we can combine the logic with preset-env's useBuiltIns.
Hopefully this makes sense, feel free to edit cc @loganfsmyth
Metadata
Metadata
Assignees
Labels
area: helpersoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue