-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Refactor transform-classes #7202
Copy link
Copy link
Closed
Labels
PR: Polish 💅A type of pull request used for our changelog categoriesA type of pull request used for our changelog categoriesi: discussionoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue
Description
At the moment transform-classes has 2 modes - regular one and loose. The loose mode is extending VanillaTransformer class. It seems to me that this hierarchical structure here is clunky and harder to maintain.
Don't know how others feel, but imho it would be nice to refactor this into a flat structure and reuse code between 2 transforms if possible, but more in a composition manner than with inheritance.
I'd like to have at least 2-3 upvotes from other core team members for this, before anyone starts to work on this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
PR: Polish 💅A type of pull request used for our changelog categoriesA type of pull request used for our changelog categoriesi: discussionoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue