-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add support for Samsung Internet browser #6602
Copy link
Copy link
Labels
importedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issuepkg: preset-env
Description
Issue originally reported by @philipwalton in babel/babel-preset-env#428
Samsumg Internet uses Chromium under the hood, but it doesn't always stay up-to-date with the latest version. We discovered this recently due to a bug report from a Samsung Internet user.
To fix it, we had to investigate the version of Chromium they use and then manually add that to the browser list:
const babelPlugin = babel({
presets: [['env', {
targets: {
browsers: ['chrome >= 51'],
},
// ...
});But this requires a bit or work on the user's side. Since browserlist support Samsung Internet, ideally we'd be able to do this:
const babelPlugin = babel({
presets: [['env', {
targets: {
browsers: ['last 2 Samsung versions'],
},
// ...
});I haven't looked into whether this can be done solely on the babel-preset-env side, or if it would require changes to http://kangax.github.io/compat-table. If the latter is the case, maybe we can loop in @poshaughnessy for help making that happen?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
importedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issuepkg: preset-env