-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Closed
Labels
Has PRPR: Spec Compliance 👓A type of pull request used for our changelog categoriesA type of pull request used for our changelog categoriesPriority: HighSpec: Class FieldsclaimedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue
Description
Reference: babel/proposals#19
- Move class properties from Stage 2 to 3. This means making a change similar to 5492fe1 where you move the plugin to the next stage
- Change the spec option to be the "normal" option. You can find the references to
"spec"withstate.opts.specor just grepping forspec. This means we want the default behavior to become what is currently "spec". Similarly we want the "normal option to be "loose" now.- In essence we are removing the spec option entirely and adding a loose option.
- spec -> default, default -> loose
- Comment below you are going to do this (for others to know)
- Read CONTRIBUTING.md
- Check you are on 7.0 branch with
git checkout 7.0and then make a branch off of that to PR - Join our slack if you haven't already if you need more immediate help or just comment in this issue/PR
- check the class properties package/folder: https://github.com/babel/babel/tree/7.0/packages/babel-plugin-transform-class-properties
- follow the steps above in changing the behavior for src/
- test/ fixtures folder https://github.com/babel/babel/tree/7.0/packages/babel-plugin-transform-class-properties/test/fixtures. I guess you could rename general/ to loose/ and spec/ to general/?
- update the readme as well
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Has PRPR: Spec Compliance 👓A type of pull request used for our changelog categoriesA type of pull request used for our changelog categoriesPriority: HighSpec: Class FieldsclaimedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue