Skip to content

[Bug]: Fragments no longer work in mithril #15353

@pdfabbro

Description

@pdfabbro

💻

  • Would you like to work on a fix?

How are you using Babel?

babel-loader (webpack)

Input code

unfortunately I can't provide a repo as it's from my company's gitlab which is private

Configuration file name

babel.config.js

Configuration

module.exports = {
	presets: ["@babel/preset-env"],
	plugins: [
		"@babel/plugin-proposal-object-rest-spread",
		["babel-plugin-root-import", { rootPathSuffix: "src" }],
		[
			"@babel/plugin-transform-react-jsx",
			{
				pragma: "m",
				pragmaFrag: "'['"
			}
		]
	],
	sourceMaps: true,
	retainLines: true,
	env: {
		test: {
			plugins: ["@babel/plugin-transform-modules-commonjs"]
		}
	}
};

Current and expected behavior

when upgrading from 7.19.0 to 7.20.7 my mithril application stops working. I have followed the steps outlined on their page and it was workign previously https://mithril.js.org/jsx.html. Note that I am using babel.config.js though, not .babelrc as they recommend. The issue seems to be with how 7.20.7 is recognizing my fragments. When I change them to divs the application no longer fails but doesn't render properly because I would have to modify all the CSS to handle all the new nested divs.

I can't seem to find a list of what was changed from 7.19.0 ti 7.20.7 or the steps involved to upgrade my application

Environment

System:
OS: Windows 10 10.0.19045
Binaries:
Node: 16.13.1 - C:\Program Files\nodejs\node.EXE
npm: 8.14.0 - C:\Program Files\nodejs\npm.CMD
npmPackages:
@babel/plugin-proposal-object-rest-spread: ^7.20.7 => 7.20.7
@babel/plugin-transform-react-jsx: ^7.20.7 => 7.20.7
@babel/preset-env: ^7.20.2 => 7.20.2
babel-eslint: ^10.1.0 => 10.1.0
babel-jest: ^29.3.1 => 29.3.1
babel-loader: ^9.1.2 => 9.1.2
babel-plugin-root-import: ^6.6.0 => 6.6.0
jest: ^29.3.1 => 29.3.1
webpack: ^5.75.0 => 5.75.0

Possible solution

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: jsxi: regressionoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions