Avoid test-typescript fails

sosukesuzuki · sosukesuzuki · commit ba0bc8e2f8c5 · 2020-09-15T02:19:21.000+09:00
diff --git a/packages/babel-parser/src/parser/statement.js b/packages/babel-parser/src/parser/statement.js
@@ -1083,7 +1083,7 @@ export default class StatementParser extends ExpressionParser {
       node.id = this.parseFunctionId();
     }
 
-    this.parseFunctionParams(node);
+    this.parseFunctionParams(node, /* allowModifiers */ false);
 
     // For the smartPipelines plugin: Disable topic references from outer
     // contexts within the function body. They are permitted in function
diff --git a/packages/babel-parser/src/plugins/typescript/index.js b/packages/babel-parser/src/plugins/typescript/index.js
@@ -1709,10 +1709,14 @@ export default (superClass: Class<Parser>): Class<Parser> =>
       const startPos = this.state.start;
       const startLoc = this.state.startLoc;
 
-      const accessibility = this.parseAccessModifier();
-      const readonly = !!this.tsParseModifier(["readonly"]);
-      if (!allowModifiers && (accessibility || readonly)) {
-        this.raise(startPos, TSErrors.UnexpectedParameterModifier);
+      let accessibility: ?N.Accessibility;
+      let readonly = false;
+      if (allowModifiers !== undefined) {
+        accessibility = this.parseAccessModifier();
+        readonly = !!this.tsParseModifier(["readonly"]);
+        if (allowModifiers === false && (accessibility || readonly)) {
+          this.raise(startPos, TSErrors.UnexpectedParameterModifier);
+        }
       }
 
       const left = this.parseMaybeDefault();

Original file line number	Diff line number	Diff line change
`@@ -1083,7 +1083,7 @@ export default class StatementParser extends ExpressionParser {`
`1083`	`1083`	`node.id = this.parseFunctionId();`
`1084`	`1084`	`}`
`1085`	`1085`
`1086`		`- this.parseFunctionParams(node);`
	`1086`	`+ this.parseFunctionParams(node, /* allowModifiers */ false);`
`1087`	`1087`
`1088`	`1088`	`// For the smartPipelines plugin: Disable topic references from outer`
`1089`	`1089`	`// contexts within the function body. They are permitted in function`