fix: properly wrap private class methods

JLHwung · JLHwung · commit b13fee587e41 · 2020-10-15T20:11:29.000-04:00
diff --git a/packages/babel-helper-wrap-function/src/index.js b/packages/babel-helper-wrap-function/src/index.js
@@ -124,7 +124,7 @@ function plainFunction(path: NodePath, callId: Object) {
 }
 
 export default function wrapFunction(path: NodePath, callId: Object) {
-  if (path.isClassMethod() || path.isObjectMethod()) {
+  if (path.isMethod()) {
     classOrObjectMethod(path, callId);
   } else {
     plainFunction(path, callId);
diff --git a/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/input.js b/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/input.js
@@ -0,0 +1,8 @@
+class C {
+  async * #g() {
+    this;
+    await 1;
+    yield 2;
+    return 3;
+  }
+}
diff --git a/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/options.json b/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": ["external-helpers", "proposal-private-methods", "proposal-async-generator-functions"]
+}
diff --git a/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/output.js b/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/class-private-method/output.js
@@ -0,0 +1,19 @@
+var _g = new WeakSet();
+
+class C {
+  constructor() {
+    _g.add(this);
+  }
+
+}
+
+var _g2 = function _g2() {
+  var _this = this;
+
+  return babelHelpers.wrapAsyncGenerator(function* () {
+    _this;
+    yield babelHelpers.awaitAsyncGenerator(1);
+    yield 2;
+    return 3;
+  })();
+};

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ function plainFunction(path: NodePath, callId: Object) {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`export default function wrapFunction(path: NodePath, callId: Object) {`
`127`		`- if (path.isClassMethod() \|\| path.isObjectMethod()) {`
	`127`	`+ if (path.isMethod()) {`
`128`	`128`	`classOrObjectMethod(path, callId);`
`129`	`129`	`} else {`
`130`	`130`	`plainFunction(path, callId);`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "plugins": ["external-helpers", "proposal-private-methods", "proposal-async-generator-functions"]`
	`3`	`+}`