Fix: Temporary files created by the test are not removed. (#14573)

liuxingbaoyu · web-flow · commit 7afb2f7062af · 2022-06-10T14:32:27.000-04:00
* fix

* review
diff --git a/packages/babel-core/package.json b/packages/babel-core/package.json
@@ -71,7 +71,8 @@
     "@types/convert-source-map": "^1.5.1",
     "@types/debug": "^4.1.0",
     "@types/resolve": "^1.3.2",
-    "@types/semver": "^5.4.0"
+    "@types/semver": "^5.4.0",
+    "rimraf": "^3.0.0"
   },
   "conditions": {
     "BABEL_8_BREAKING": [
diff --git a/packages/babel-core/test/config-chain.js b/packages/babel-core/test/config-chain.js
@@ -3,6 +3,7 @@ import os from "os";
 import path from "path";
 import { fileURLToPath } from "url";
 import babel from "../lib/index.js";
+import rimraf from "rimraf";
 
 import _getTargets from "@babel/helper-compilation-targets";
 const getTargets = _getTargets.default;
@@ -68,14 +69,24 @@ function escapeRegExp(string) {
   return string.replace(/[|\\{}()[\]^$+*?.]/g, "\\$&");
 }
 
+const tempDirs = [];
+
 async function getTemp(name) {
-  const cwd = await pfs.mkdtemp(os.tmpdir() + path.sep + name);
+  const tempDir = os.tmpdir() + path.sep + name;
+  tempDirs.push(tempDir);
+  const cwd = await pfs.mkdtemp(tempDir);
   const tmp = name => path.join(cwd, name);
   const config = name =>
     pfs.copyFile(fixture("config-files-templates", name), tmp(name));
   return { cwd, tmp, config };
 }
 
+afterAll(() => {
+  for (const dir of tempDirs) {
+    rimraf.sync(dir);
+  }
+});
+
 describe("buildConfigChain", function () {
   describe("test", () => {
     describe("single", () => {
diff --git a/yarn.lock b/yarn.lock
@@ -343,6 +343,7 @@ __metadata:
     debug: ^4.1.0
     gensync: ^1.0.0-beta.2
     json5: ^2.2.1
+    rimraf: ^3.0.0
     semver: "condition:BABEL_8_BREAKING ? ^7.3.4 : ^6.3.0"
   languageName: unknown
   linkType: soft
