Keep import statement if all of specifiers are type-only one

sosukesuzuki · sosukesuzuki · commit 4d1cde6ae2cf · 2021-10-11T19:35:41.000+09:00
diff --git a/packages/babel-plugin-transform-typescript/src/index.ts b/packages/babel-plugin-transform-typescript/src/index.ts
@@ -288,7 +288,7 @@ export default declare((api, opts) => {
                 }
               }
 
-              if (isAllSpecifiersElided()) {
+              if (!onlyRemoveTypeImports && isAllSpecifiersElided()) {
                 stmt.remove();
               } else {
                 for (const importPath of importsToRemove) {
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/imports/only-remove-type-imports/output.mjs b/packages/babel-plugin-transform-typescript/test/fixtures/imports/only-remove-type-imports/output.mjs
@@ -5,5 +5,6 @@ import d, { d2 } from "d";
 import e, { e3 as e4 } from "e";
 import "f";
 import "g";
+import "k";
 import { L2 } from "l";
 ;
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/input.ts b/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/input.ts
@@ -0,0 +1 @@
+import { type A } from "x";
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/options.json b/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/options.json
@@ -0,0 +1,10 @@
+{
+  "plugins": [
+    [
+      "transform-typescript",
+      {
+        "onlyRemoveTypeImports": true
+      }
+    ]
+  ]
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/output.mjs b/packages/babel-plugin-transform-typescript/test/fixtures/imports/type-only-import-specifier-4/output.mjs
@@ -0,0 +1 @@
+import "x";

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ export default declare((api, opts) => {`
`288`	`288`	`}`
`289`	`289`	`}`
`290`	`290`
`291`		`- if (isAllSpecifiersElided()) {`
	`291`	`+ if (!onlyRemoveTypeImports && isAllSpecifiersElided()) {`
`292`	`292`	`stmt.remove();`
`293`	`293`	`} else {`
`294`	`294`	`for (const importPath of importsToRemove) {`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@ import d, { d2 } from "d";`
`5`	`5`	`import e, { e3 as e4 } from "e";`
`6`	`6`	`import "f";`
`7`	`7`	`import "g";`
	`8`	`+import "k";`
`8`	`9`	`import { L2 } from "l";`
`9`	`10`	`;`