Skip to content

Support XDG Trash specification#69

Merged
babarot merged 21 commits intomainfrom
babarot/xdg
Feb 16, 2025
Merged

Support XDG Trash specification#69
babarot merged 21 commits intomainfrom
babarot/xdg

Conversation

@babarot
Copy link
Copy Markdown
Owner

@babarot babarot commented Feb 15, 2025

This pull request introduces a comprehensive redesign of gomi's trash management system, providing a more robust, flexible, and standards-compliant approach to file deletion and restoration.

ref #59

What

  • Implemented a new multi-strategy trash management architecture
  • Added full support for XDG trash specification
  • Maintained backward compatibility with legacy gomi trash format
  • Enhanced configuration options for trash management
  • Improved cross-device file movement and restoration

Why

The new architecture addresses several key challenges in CLI trash management:

  1. Standards Compliance: Full adherence to the XDG trash specification ensures compatibility with modern desktop environments.
  2. Flexibility: Users can choose between XDG, legacy, and auto trash strategies.
  3. Reliability: Improved error handling and support for different storage backends.
  4. Performance: More efficient file tracking and restoration processes.

Notes

Breaking Changes

Migration Path

  • Existing configurations will be automatically migrated
  • Users can specify preferred trash strategy in the config file

@babarot babarot added kind/feature A feature request; new or enhanced behavior release/minor Indicates minor version to bump up next when creating release PR. labels Feb 15, 2025
Copy link
Copy Markdown

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is partial review made on my phone.

Here are some feedbacks, they are minors

The PR is great

@babarot
Copy link
Copy Markdown
Owner Author

babarot commented Feb 15, 2025

Thank you for the review @ccoVeille

I’ll read it later and take action. Updated!

@babarot babarot merged commit 241fc82 into main Feb 16, 2025
5 checks passed
@babarot babarot deleted the babarot/xdg branch February 16, 2025 07:26
@github-actions github-actions bot mentioned this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature A feature request; new or enhanced behavior release/minor Indicates minor version to bump up next when creating release PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants