Skip to content

Feature | Support Nested dynamic fields #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
midnight-studios wants to merge 15 commits into from
Closed

Feature | Support Nested dynamic fields #56

midnight-studios wants to merge 15 commits into from

Conversation

@midnight-studios
Copy link
Contributor

@midnight-studios midnight-studios commented Nov 29, 2017 •
edited
Loading

@midnight-studios
Support dynamic fields inside dynamic fields
c0ef7e6 
Updated Ajax/jquery calls: onclick for "Add" & "Remove" links
@midnight-studios
Added support to recursively load dynamic settings
b6d7d14 
Support dynamically created values inside dynamic fields
@midnight-studios
Fix handle array keys in plugin settings
5677929 
Recursion assumes variable is an array, but it breaks if the variable is a string
@midnight-studios
Info: Default Values for Nested 'input_group'
9040397 
See http://forums.b2evolution.net/support-dynamic-fields-inside-dynamic-fields
See b2evolution@30b6063
See http://forums.b2evolution.net/bug-6-9-x-dynamic-plugin-settings-and-1
@midnight-studios
Get default value for Nested plugin fields
620d3d7
@midnight-studios
Reverted: Get default value for Nested plugin fields
c07b9c4
@midnight-studios
Fixed element id variable
d616fff 
'Remove' on click action
@midnight-studios
Fix ignoring of default values for nested dynamic plugin settings
176e169 
# Conflicts:
#	inc/plugins/_plugin.funcs.php
@midnight-studios
Fix ignoring of default values for nested dynamic plugin settings
da57927 
# Conflicts:
#	inc/plugins/_plugin.funcs.php
@midnight-studios
Copy link
Contributor Author

midnight-studios commented Dec 19, 2017

Tested this and it seems to work as expected. There is a conflict though if the fold property is set where it causes the remove link to break.

@midnight-studios
Copy link
Contributor Author

midnight-studios commented Dec 19, 2017

All sorted.
Everything works on testing.

@midnight-studios midnight-studios changed the title Support Nested dynamic fields Feature | Support Nested dynamic fields Feb 25, 2018
@fplanque fplanque added the Unclear goal It is unclear why we need to add this code/feature (besides "because we can") label Apr 5, 2018
@midnight-studios
Copy link
Contributor Author

midnight-studios commented Apr 6, 2018 •
edited
Loading

Please see this PR here for a full presentation:

#76

@midnight-studios midnight-studios mentioned this pull request Apr 12, 2018
Merged
@midnight-studios midnight-studios mentioned this pull request Jul 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Unclear goal It is unclear why we need to add this code/feature (besides "because we can")

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@midnight-studios @fplanque