Fix the azd add not working bug in sjad #104
Merged
saragluna merged 2 commits intoJan 13, 2025
Merged
Conversation
haoozhang
approved these changes
Jan 13, 2025
haoozhang
reviewed
Jan 13, 2025
|
|
||
| for { | ||
| dbName, err := console.Prompt(ctx, input.ConsoleOptions{ | ||
| Message: fmt.Sprintf("Input the name of the app database (%s)", r.Type.String()), |
Author
There was a problem hiding this comment.
One for server, one for database
Author
|
Seems like the test coverage can pass on my local machine, will try to merge this first. |
rujche
reviewed
Jan 15, 2025
| } | ||
| { | ||
| principalId: principalId | ||
| principalType: 'ServicePrincipal' |
There was a problem hiding this comment.
- FYI: This caused this bug: https://github.com/azure-javaee/azure-dev/pull/105/files#r1916217093
- Why is this necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
azd addnot working bug in sjad Azure#4473 (comment)