fix: no handlong invalid url

azu · azu · commit e800ce019231 · 2021-01-30T15:27:40.000+09:00
diff --git a/src/mdImg.ts b/src/mdImg.ts
@@ -5,8 +5,5 @@ export type MdImgOptions = {
     alt?: string;
 };
 export const mdImg = ({ url, alt = "" }: MdImgOptions): string => {
-    if (!/^https?:/.test(url)) {
-        return alt;
-    }
     return `![${mdEscape(alt)}](${url})`;
 };
diff --git a/src/mdLink.ts b/src/mdLink.ts
@@ -6,10 +6,6 @@ export type MdLinkOptions = {
     title?: string;
 };
 export const mdLink = ({ text, url, title }: MdLinkOptions): string => {
-    const isURL = /^https?:/.test(url);
-    if (!isURL) {
-        return text;
-    }
     if (title) {
         return `[${mdEscape(text)}](${url} "${mdEscape(title)}")`;
     }
diff --git a/test/mdImg.test.ts b/test/mdImg.test.ts
@@ -3,8 +3,7 @@ import assert from "assert";
 
 const properties: [actual: MdImgOptions, expected: string][] = [
     [{ alt: "alt", url: "https://example.com" }, `![alt](https://example.com)`],
-    [{ url: "https://example.com" }, `![](https://example.com)`],
-    [{ url: "invalid url", alt: "alt" }, `alt`]
+    [{ url: "https://example.com" }, `![](https://example.com)`]
 ];
 describe("mdImg", function () {
     properties.forEach((property) => {
diff --git a/test/mdLink.test.ts b/test/mdLink.test.ts
@@ -8,9 +8,7 @@ const properties: [actual: MdLinkOptions, expected: string][] = [
     [
         { text: "<s>**strong**</s>", url: "https://example.com" },
         `[&lt;s&gt;\\*\\*strong\\*\\*&lt;\\/s&gt;](https://example.com)`
-    ],
-    // illegal url
-    [{ text: "text", url: "javascript:alert(1)" }, `text`]
+    ]
 ];
 describe("mdLink", function () {
     properties.forEach((property) => {
