Skip to content

Commit f457cee

Browse files
committed
don't compare resolver data to as it is not url-decoded.
Signed-off-by: azjezz <azjezz@protonmail.com>
1 parent 6d851d4 commit f457cee

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tests/RouterTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public function testMethodNotAllowedResponses(string $_name, callable $factory):
148148
[$responder, $_data] = $router->routeMethodAndPath(HttpMethod::HEAD, '/get');
149149

150150
self::assertSame('get', $responder);
151-
151+
152152
// GET -> HEAD
153153
try {
154154
$router->routeMethodAndPath(HttpMethod::GET, '/head');
@@ -204,10 +204,10 @@ public function testAllResolvers(string $_resolver_name, IResolver $resolver, st
204204
self::assertSame($expected_responder, $responder);
205205
self::assertSame($expected_data, $data);
206206

207-
[$responder, $data] = $resolver->resolve(HttpMethod::GET, $in);
207+
// don't compare $_data to $expected_data as it is not url-decoded, that is done by the router.
208+
[$responder, $_data] = $resolver->resolve(HttpMethod::GET, $in);
208209

209210
self::assertSame($expected_responder, $responder);
210-
self::assertSame($expected_data, $data);
211211

212212
[$responder, $data] = $this->getRouter()->setResolver($resolver)->routeMethodAndPath(HttpMethod::HEAD, $in);
213213

@@ -281,7 +281,7 @@ private function typeCheckCovariantTResponder(BaseRouter $_1, BaseRouter $_2): v
281281

282282
/**
283283
* @param null|array<non-empty-string, array<string, string>> $routes
284-
*
284+
*
285285
* @return TestRouter<string>
286286
*/
287287
private function getRouter(?array $routes = null): TestRouter

0 commit comments

Comments
 (0)