Fix cli flags order#149
Merged
azimjohn merged 1 commit intoazimjohn:masterfrom May 17, 2023
mmkamron:args
Merged
Conversation
Owner
|
Thanks Kamron, indeed parsing flags are getting out of hand. The problem is there're 3 types of args {"subcommand", "-key value", "--flag"}. Standard flag package doesn't have definitions for all these types and may require passing protocol as "--protocol or -p" and it's not good. Post a PR if you think it's possible to do it cleaner way. |
Contributor
Author
|
There is a NewFlagSet function in the flag package, maybe that's what we need to use in this case. Because current if-else trick worries me. Here is a basic overview. By the way, I admire you implementing many functions yourself thus minimizing the dependencies and libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
After recent changes, there is a little confusion in the flags order. If a user has a flag
-sfor the subdomain feature, it doesn't work. However, it works when there is also a--debugoption in the last parameter. This PR will temporarily fix that issue. I'd suggest using Go's flag package as more options may appear in the future.