Skip to content

fix(SAI/Conditions) - Match the core values for SAI waypoints and update readiablity for SAI and Conditions Source Types#3598

Merged
Helias merged 12 commits into
azerothcore:masterfrom
TheSCREWEDSoftware:sai_waypoint
Oct 19, 2025
Merged

fix(SAI/Conditions) - Match the core values for SAI waypoints and update readiablity for SAI and Conditions Source Types#3598
Helias merged 12 commits into
azerothcore:masterfrom
TheSCREWEDSoftware:sai_waypoint

Conversation

@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor

Closes: #3591 // AI action 53 and 113 need update
Closes: #3222 // Add Numeric Values to Source Type for SAI_TYPE_% and CONDITION_SOURCE_TYPE_%


Before:

image image image image image image

After

image image image image image image

@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor Author

Forgot above

Before:
image

After:
image

CC @FrancescoBorzi ãnd @Helias

Note: I wished I knew how to change the default value that appears on the conditions and smart ai search without hijacking the on init from ng if it's posible tried selected]="key === 0" to no sucucess on the html part, i think it should by default always show the enum 0.

Also i "added" ALL for SAI because we had it as the "empty" option but now we have aproper text and it's on the bottom as is the less commun option, conditions doesnt need it as they have "NONE" which shows all.

image image image

Comment thread libs/features/conditions/src/select-conditions/select-conditions.component.html Outdated
@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor Author

Search bby existing SAI
image

image

Search by Entitiy
image

Conditions
image

Example of spanishj (missing translation)
image

image image image

@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor Author

@Helias if you may review again, now everything for SAI and Conditions menu have translation, and translation keys and SAI is under the correct translation structure!

@Helias Helias merged commit 5681acc into azerothcore:master Oct 19, 2025
12 checks passed
@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor Author

Forgot to ask 💀 if translation keys from the english file get moved, removed or renamed, does the other language correctly match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAI action 53 and 113 need update [Enchantment] Add Numeric Values to Source Type for SAI_TYPE_% and CONDITION_SOURCE_TYPE_%

2 participants