feat: SSL/TLS implementation for require_secure_transport#3558
Conversation
|
CC @FrancescoBorzi and @Helias |
|
This I may need help fixing, as I'm unsure now from the error, it does build fine in windows and works |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
// SET GLOBAL require_secure_transport = ON; Unchecked = Error, intended Checked = No error, intended And thanks helias for adjusting it to the Keira standards |
| needs: get-package-version | ||
| name: Build and upload the Mac release assets | ||
| runs-on: macos-13 # it's the most recent version still running on Intel, we keep it for retro-compatibility | ||
| runs-on: macos-15 # it's the most recent version still running on Intel, we keep it for retro-compatibility |
There was a problem hiding this comment.
this does not seem right (also should be addressed in a separate PR, not here):
https://docs.github.com/en/actions/reference/runners/github-hosted-runners
the rest I will check soon! thanks @TheSCREWEDSoftware <3
For the other question, I can't answer, i leave it to be answered by helias :p |
|
I swear to god i wish keira worked with github desktop so i dont have to use the git cli which sometimes is stupid |
|
Can test this during the afternoon |
…ftware/Keira3 into secure_connection_2
|
All working |
This implementation allows people that have require_secure_transport enabled.
Closes: #3556
#3556 (comment)
Being tested by the issue author also.
I tried following the current config sturcutre that's being used, I'm unsure about the description for the SSL/TLS, im just thinking of having it without a description, open to feedback.
This can be tested if you want on your side by using your super user for mysql and running the following:
And having TLS option off.
And having TLS option on