fix(sort-imports): fix weak json schema typings generated

hugop95 · web-flow · commit 45306fa67b59 · 2025-04-25T18:24:14.000+03:00
diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -464,41 +464,9 @@ export default createEslintRule<Options, MESSAGE_ID>({
           internalPattern: regexJsonSchema,
           groups: groupsJsonSchema,
         },
-        allOf: [
-          {
-            $ref: '#/definitions/max-line-length-requires-line-length-type',
-          },
-        ],
-        dependencies: {
-          maxLineLength: ['type'],
-        },
         additionalProperties: false,
         type: 'object',
       },
-      definitions: {
-        'max-line-length-requires-line-length-type': {
-          anyOf: [
-            {
-              not: {
-                required: ['maxLineLength'],
-                type: 'object',
-              },
-              type: 'object',
-            },
-            {
-              $ref: '#/definitions/is-line-length',
-            },
-          ],
-        },
-        'is-line-length': {
-          properties: {
-            type: { enum: ['line-length'], type: 'string' },
-          },
-          required: ['type'],
-          type: 'object',
-        },
-      },
-      id: 'sort-imports',
       uniqueItems: true,
       type: 'array',
     },
diff --git a/test/utils/validate-rule-json-schema.ts b/test/utils/validate-rule-json-schema.ts
@@ -3,6 +3,8 @@ import type { JSONSchema4 } from '@typescript-eslint/utils/json-schema'
 import { compile as compileSchemaForTs } from 'json-schema-to-typescript-lite'
 import Ajv from 'ajv-draft-04'
 
+import { commonJsonSchemas } from '../../utils/common-json-schemas'
+
 export let validateRuleJsonSchema = async (
   schemaOrSchemas: readonly JSONSchema4[] | JSONSchema4,
 ): Promise<void> => {
@@ -18,5 +20,21 @@ export let validateRuleJsonSchema = async (
 
 let validateJsonSchema = async (schema: JSONSchema4): Promise<void> => {
   new Ajv().compile(schema)
-  await compileSchemaForTs(schema, 'id')
+  await validateTsJsonSchema(schema)
+}
+
+let validateTsJsonSchema = async (schema: JSONSchema4): Promise<void> => {
+  let generatedTypescript = await compileSchemaForTs(schema, 'id')
+  for (let [commonJsonSchemaKey, commonJsonSchema] of Object.entries(
+    commonJsonSchemas,
+  )) {
+    if (
+      commonJsonSchema.description &&
+      !generatedTypescript.includes(commonJsonSchema.description)
+    ) {
+      throw new Error(
+        `TypeScript generated from JSON schema seems wrong: no description found for ${commonJsonSchemaKey}:\n${generatedTypescript}`,
+      )
+    }
+  }
 }
