Skip to content

fix: field chainId should be acceptable for eth_estimateGas#1601

Merged
Flouse merged 1 commit intomainfrom
yangby/bugfix/required-jsonrpc-fields
Nov 28, 2023
Merged

fix: field chainId should be acceptable for eth_estimateGas#1601
Flouse merged 1 commit intomainfrom
yangby/bugfix/required-jsonrpc-fields

Conversation

@chaoticlonghair
Copy link
Contributor

What this PR does / why we need it?

This PR resolves #1583.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

p.s. This PR is created via GitHub CLI.

@chaoticlonghair
Copy link
Contributor Author

/run-ci

p.s. This comment is created via GitHub CLI.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@chaoticlonghair chaoticlonghair marked this pull request as ready for review November 28, 2023 02:01
@chaoticlonghair chaoticlonghair requested a review from a team as a code owner November 28, 2023 02:01
@KaoImin KaoImin enabled auto-merge November 28, 2023 02:09
@KaoImin KaoImin added this pull request to the merge queue Nov 28, 2023
@Flouse Flouse mentioned this pull request Nov 28, 2023
6 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2023
@Flouse Flouse added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit adceffa Nov 28, 2023
@KaoImin KaoImin deleted the yangby/bugfix/required-jsonrpc-fields branch November 28, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The filed chainId is required, but eth_estimateGas rejects it.

4 participants