refactor: change the calculation of receipts root to EIP-2718#1486
Merged
wenyuanhust merged 2 commits intoaxonweb3:mainfrom Oct 20, 2023
Merged
refactor: change the calculation of receipts root to EIP-2718#1486wenyuanhust merged 2 commits intoaxonweb3:mainfrom
wenyuanhust merged 2 commits intoaxonweb3:mainfrom
Conversation
ca97190 to
dad6b1e
Compare
KaoImin
reviewed
Oct 20, 2023
KaoImin
approved these changes
Oct 20, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR modifies receipt root calculation procedure based on eip-2718.
In the previous implementation. A receipt is inserted into receipt trie in the following steps:
however, according to eip2718, step 2-3 is unnecessary.
we need to decide whether to in consistence with Ethereum standards or not.
What is the impact of this PR?
This will change the receipt root kept in block.
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description